Repository navigation
Update dependencies - #5554
Closed
pierlon wants to merge 60 commits into
Closed
Update dependencies#5554pierlon wants to merge 60 commits into
pierlon wants to merge 60 commits into
Conversation
pierlon
added
dependencies
v2.9.1 of the plugin dropped support for Composer v1, see ergebnis/composer-normalize#597
pierlon
marked this pull request as ready for review
November 1, 2020 04:58
Member
|
A build is failing with an error:
|
Contributor
|
Plugin builds for 36fe212 are ready 🛎️!
|
Contributor
Author
Should now be resolved in 36fe212. |
westonruter
approved these changes
Nov 2, 2020
westonruter
left a comment
westonruter
left a comment
Member
There was a problem hiding this comment.
LGTM! Awaiting +1 from @johnwatkins0.
This was referenced Nov 2, 2020
Update dependencies
Member
|
@pierlon there appear to be conflicts which need resolving before I can merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The following dependencies cannot be updated as yet:
The
webpackdependency cannot be updated to v5 as yet until the Gutenberg packages we use support it (currently being worked on in Upgrade webpack to version 5 WordPress/gutenberg#26382);The
terser-webpack-plugindependency cannot be updated to v5 as it needswebpackv5;The
phpdocumentor/reflectiondependency cannot be updated to v4 due to incompatible PHP version constraints (and even if it were updated our current doc generation command will break).Apart from that, the localheinz/composer-normalize dependency (used in the Travis lint job) has been abandoned and is replaced with its successor, ergebnis/composer-normalize. The dependency is locked to v2.9.0 as the latest release (v2.9.1) has dropped support for Composer v1.
Other miscellaneous changes:
webpack-clidependency has been removed as it does not seem to be in use by the plugin.In total, 51 dependencies are updated.
Checklist