[pierlon]

Summary

Bumps the coverage threshold for the php and js projects from 0% to 0.1%

Checklist

• My pull request is addressing an open issue (please create one otherwise).
• My code is tested and passes existing tests.
• My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

[pierlon]

Would love to get @schlessera's feedback on this to see if we would be shooting ourselves in the foot with this change.

[github-actions]

Plugin builds for dffc5c4 are ready 🛎️!

• Download development build
• Download production build

[schlessera]

@pierlon I might be missing something here: It looks from the diff like you're overriding the default threshold: 0.1% with language-specific settings of that very same threshold... ?

[pierlon]

@schlessera the Codecov docs gives the impression that the default threshold is applied to the language-specific settings, but in practice that has turned out to be false. We've been having PR checks fail even when the threshold is below the expected 0.1%.

To verify this I forked the project and tested my hypothesis. As you can see in pierlon#3, at pierlon@424ddda the codecov php test failed when it decreased by 0.01%. When I set the threshold to 0.1% for php in pierlon@384e224, the coverage test passed.

[schlessera]

Alright. I do think that looks like a bug in CodeCov, it does not make full sense the way I read the configs.

[schlessera]

Let's try and see how this goes. Right now, I think our code coverage is a bit flaky overall because it use pcov, which seems to have trouble flagging everything it should...