Repository navigation
Run ESLint on PR fork without generating report - #5876
Conversation
b893674 to
824b36d
Compare
|
Plugin builds for 824b36d are ready 🛎️!
|
westonruter
left a comment
There was a problem hiding this comment.
This will prevent the following from happening as in #5871:
Correct?
Why again is it that without this change, the step is skipped?
I believe I'll also need to remove this from the required checks for the tests to pass:
It should not have been showing in the first place since the action that creates the check did not run at all.
I wonder if that's the reason why the check appears even when the
I suppose you mean the "Annotate code linting results" step. That was set to skip in #5656. |
|
|
||
| - name: Detect coding standard violations (ESLint) | ||
| - name: Detect ESLint coding standard violations | ||
| if: github.event.pull_request.head.repo.fork == true |
There was a problem hiding this comment.
Ah, npm run lint:js:report also does the linting, so that is why this is is limited to forks.



Summary